Skip to content

gh-144363: Update bundled libexpat to 2.7.4 #144365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 5 commits into from
Feb 5, 2026
Merged

gh-144363: Update bundled libexpat to 2.7.4 #144365

encukou merged 5 commits into from
Feb 5, 2026

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 31, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 31, 2026
Open
@StanFromIreland StanFromIreland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 31, 2026
@gpshead gpshead self-assigned this Feb 1, 2026
gpshead
gpshead approved these changes Feb 1, 2026
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this matches expat 2.7.4 - i committed a minor tweak to keep the COPYING file in sync.

@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2026
@bedevere-bot
Copy link

bedevere-bot commented Feb 1, 2026

🤖 New build scheduled with the buildbot fleet by @gpshead for commit c305ac7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144365%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 1, 2026
encukou
encukou reviewed Feb 4, 2026
View reviewed changes
Modules/expat/COPYING
@@ -1,5 +1,5 @@
Copyright (c) 1998-2000 Thai Open Source Software Center Ltd and Clark Cooper
Copyright (c) 2001-2022 Expat maintainers
Copyright (c) 2001-2025 Expat maintainers
Copy link
Member

@encukou encukou Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Doc/license.rst change as well?

Copy link
Member

@gpshead gpshead Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably so if it correctly contains a copy of this one. if we haven't automated updating that from the various scattered license sources of truth that could be a followup rather than blocking this. the listed date extension is not material to a license's validity.

Copy link
Member Author

@StanFromIreland StanFromIreland Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we remove the double maintenance burden, see #144488.

@StanFromIreland StanFromIreland mentioned this pull request Feb 4, 2026
Merged
@encukou encukou merged commit d5cb9f6 into python:main Feb 5, 2026
50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 5, 2026

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead
@encukou @miss-islington
pythongh-144363: Update bundled libexpat to 2.7.4 (pythonGH-144365)
61ac68f 
* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------
(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead
@encukou @miss-islington
pythongh-144363: Update bundled libexpat to 2.7.4 (pythonGH-144365)
90e913e 
* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------
(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144499 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 5, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 5, 2026

Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d5cb9f6a9b6f48cc08c4422259498d4fd023357a 3.11

@miss-islington-app miss-islington-app bot assigned encukou and unassigned gpshead Feb 5, 2026
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144500 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 5, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 5, 2026

Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d5cb9f6a9b6f48cc08c4422259498d4fd023357a 3.10

@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144501 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 5, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead
@encukou @miss-islington
pythongh-144363: Update bundled libexpat to 2.7.4 (pythonGH-144365)
59e114f 
* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------
(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@StanFromIreland StanFromIreland deleted the libexpat-2.7.4 branch February 5, 2026 13:21
encukou added a commit to encukou/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead @encukou
pythongh-144363: Update bundled libexpat to 2.7.4 (python#144365)
aa549fb 
* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead @encukou
[3.11] pythongh-144363: Update bundled libexpat to 2.7.4 (pythonGH-14…
cd73060 
…4365)

* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------
(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144514 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 5, 2026
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Feb 5, 2026
@StanFromIreland @gpshead @encukou
[3.10] pythongh-144363: Update bundled libexpat to 2.7.4 (pythonGH-14…
d3d13af 
…4365)

* Update to 2.7.4

* update expat license copyright year to match and a pedantic #define

* include COPYING update in refresh.sh

* Update checksum for copying

---------
(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144515 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Feb 5, 2026
encukou added a commit that referenced this pull request Feb 9, 2026
@miss-islington @StanFromIreland
@gpshead @encukou
[3.14] gh-144363: Update bundled libexpat to 2.7.4 (GH-144365) (GH-14…
2e3f014 
…4499)

(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou pushed a commit that referenced this pull request Feb 10, 2026
@miss-islington @StanFromIreland @gpshead
[3.13] gh-144363: Update bundled libexpat to 2.7.4 (GH-144365) (GH-14…
7fbdec4 
…4500)

(cherry picked from commit d5cb9f6)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@encukou encukou encukou left review comments

@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @bedevere-bot @gpshead @encukou