Skip to content

Invalid handling of empty values in sqlcmd #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
debarshibasak wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −4
Open

Invalid handling of empty values in sqlcmd #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e7d0f7
invalid handling of empty values in sqlcmd
debarshibasak Feb 9, 2026
3459de9
tests fixed
debarshibasak Feb 10, 2026
14713ab
Merge branch 'main' into main
debarshibasak Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/sqlcmd/sqlcmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,20 +359,20 @@ func checkDefaultValue(args []string, i int) (val string) {
'L': "|", // | is the sentinel for no value since users are unlikely to use it. It's "reserved" in most shells
'X': "0",
}
if isFlag(args[i]) && len(args[i]) == 2 && (len(args) == i+1 || args[i+1][0] == '-') {
if isFlag(args[i]) && len(args[i]) == 2 && (len(args) == i+1 || isFlag(args[i+1])) {
if v, ok := flags[rune(args[i][1])]; ok {
val = v
return
}
}
if args[i] == "-N" && (len(args) == i+1 || args[i+1][0] == '-') {
if args[i] == "-N" && (len(args) == i+1 || isFlag(args[i+1])) {
val = "true"
}
return
}

func isFlag(arg string) bool {
return arg[0] == '-'
return len(arg) > 0 && arg[0] == '-'
}

func isListFlag(arg string) bool {
Expand Down
7 changes: 6 additions & 1 deletion cmd/sqlcmd/sqlcmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,11 +584,16 @@ func TestConvertOsArgs(t *testing.T) {
[]string{"-X", "-k2"},
[]string{"-X", "0", "-k2"},
},
{
"flag with empty value",
[]string{"-S", "server", "-U", "sa", "-d", "", "-Q", "SELECT 1", "-b"},
[]string{"-S", "server", "-U", "sa", "-d", "", "-Q", "SELECT 1", "-b"},
},
}
for _, c := range tests {
t.Run(c.name, func(t *testing.T) {
actual := convertOsArgs(c.in)
assert.ElementsMatch(t, c.expected, actual, "Incorrect converted args")
assert.Equal(t, c.expected, actual, "Incorrect converted args")
})
}
}
Expand Down