-
Notifications
You must be signed in to change notification settings - Fork 323
Subscription Header Traceability #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miljance
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
miljance:SBSubscriptionHeaderTraceability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Subscription Header Traceability #6519
miljance
wants to merge
4
commits into
microsoft:main
from
miljance:SBSubscriptionHeaderTraceability
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duichwer
suggested changes
Feb 7, 2026
src/Apps/W1/Subscription Billing/App/Service Objects/Tables/SubscriptionHeader.Table.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/App/Service Objects/Tables/SubscriptionHeader.Table.al
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/App/Service Objects/Tables/SubscriptionHeader.Table.al
Outdated
Show resolved
Hide resolved
djukicmilica
previously approved these changes
Feb 9, 2026
samra-singhammer
suggested changes
Feb 9, 2026
src/Apps/W1/Subscription Billing/App/Billing/Codeunits/SalesDocuments.Codeunit.al
Show resolved
Hide resolved
…scriptionHeaderTraceability # Conflicts: # src/Apps/W1/Subscription Billing/App/Service Commitments/Pages/ServiceCommPackageLines.Page.al
JesperSchulz
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: Apps (W1)
Add-on apps for W1
Finance
GitHub request for Finance area
From Fork
Pull request is coming from a fork
Linked
Issue is linked to a Azure Boards work item
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors and enhances the Subscription Billing logic for creating Subscription Headers from sales transactions. The changes modernize the event handling by moving Subscription creation to the item journal posting process, improve data consistency by caching sales context, add new fields and data to the Subscription Header and Service Object, and streamline the handling of negative quantities. Several legacy methods are marked obsolete, and related code is cleaned up.
Event Handling and Refactoring:
OnAfterPostItemJnlLineevent, ensuring that subscriptions are created during item journal posting and not during shipment posting. Legacy methods are now marked as obsolete and wrapped in conditional compilation.GlobalSalesHeader,GlobalSalesLine) to cache sales context between event subscribers, ensuring accurate data is available during item journal posting. Added reset logic to clear these variables before and after posting.Data Model and UI Enhancements:
Subscription Headerwith new fields. Updated logic to populate these fields from related sales and item records.Negative Quantity Handling:
Sales Subscription Line Mgmt., consolidating them into the main codeunit.Code Cleanup and Dependency Updates:
Awaiting code review from @samra-singhammer or @sit-zm.
Work Item(s)
Fixes #6320
Fixes AB#612906