Fix ObjectDisposedException when disposing session after client.StopAsync() #371
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #306
When
await client.StopAsync()is called before theawait using var sessiongoes out of scope,session.DisposeAsync()is called twice:StopAsync()(while connection is alive) ✓await usingcleanup (connection is now disposed) ✗ →ObjectDisposedExceptionRepro (from issue)
Solution
Make
CopilotSession.DisposeAsync()idempotent and tolerant to already-disposed connections:_isDisposedflag - Thread-safe usingInterlocked.ExchangeDisposeAsyncidempotent - Returns immediately if already disposed (required byIAsyncDisposablecontract)ObjectDisposedExceptionandIOExceptionsince dispose methods should never throwThis follows the same pattern already used in
CopilotClient.DisposeAsync().Changes
dotnet/src/Session.cs: Add idempotency and exception handling toDisposeAsync()dotnet/test/ClientTests.cs: Add regression testTesting